Skip to content

Conversation

@reese
Copy link
Collaborator

@reese reese commented Jan 15, 2026

As of now, the difference between the Ripper and Prism implementations is quite small, and many of the diffs that are generated are mostly fixes for bugs that exist only in Ripper (or are sufficiently rare and don't affect the runtime behavior that I think we can live with them). Given how small the diff is, I don't think it's worth having a version with the --prism flag, and instead we should just shift over to Prism being the main implementation for the next release we cut. (There are probably a few small things to get in before we cut a release, like a bit more cleanup and #740, but I think we should cut one reasonably soon after that.)

The vast majority of the deletions are of course the Ripper tree types, deserialization code, and the Ruby VM checkout. There's also some deletions of token types, error types, and parser state methods that were only used by the Ripper implementation and were flagged by the compiler as dead code. There's more cleanup that we could do after this, but I wanted to keep this at a reasonable size, so I figure there would be follow-ons later.

I've done my best to break this up into commits that are somewhat-related, but I sort of worked backwards from the fully-deleted change, so each commit is not perfectly self-contained. It's mostly just to avoid having a single 8k line deletion commit.

@reese reese force-pushed the reese-ruby-embed-removal branch 3 times, most recently from 4898510 to 59631b6 Compare January 15, 2026 20:58
@reese reese force-pushed the reese-ruby-embed-removal branch from 59631b6 to e15d560 Compare January 16, 2026 15:06
@reese reese changed the title [DNM] Delete Ripper implementation 🔪 Delete Ripper implementation Jan 16, 2026
@reese reese marked this pull request as ready for review January 16, 2026 15:14
@reese reese requested a review from froydnj January 16, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants